Fix disabling lambda url cors error #229

qw-in · 2024-04-12T22:55:04Z

Previously, disabling url.cors after it had been enabled would have no effect or throw an error, this attempts to fix that.

Reproduce:

First deploy

new sst.aws.Function("Cors", {
  handler: "cors.handler",
  url: {
    cors: true,
  },
});

sst deploy
sst refresh # potentially unneeded

Second deploy

new sst.aws.Function("Cors", {
  handler: "cors.handler",
  url: {
    cors: false,
  },
});

sst deploy
×  Failed
   Cors sst:aws:Function → Cors aws:lambda:FunctionUrl
   updating urn:pulumi:...::sst:aws:Function$aws:lambda/functionUrl:FunctionUrl::Cors: 1 error occurred:
   
   InvalidParameterValueException: You can't leave AllowOrigins as empty when Cors is enabled.

After this change, cors should be disabled successfully

fwang · 2024-05-29T15:59:26Z

Thanks @qw-in!

Will be in the next release.

disable lambda url cors when false

f0ce43b

jayair requested a review from fwang April 12, 2024 23:04

qw-in changed the title ~~Fix disablling lambda url cors error~~ Fix disabling lambda url cors error Apr 15, 2024

Merge branch 'dev' into pr/229

c5ec9bb

fwang merged commit 3263630 into sst:dev May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix disabling lambda url cors error #229

Fix disabling lambda url cors error #229

qw-in commented Apr 12, 2024 •

edited

Loading

fwang commented May 29, 2024

Fix disabling lambda url cors error #229

Fix disabling lambda url cors error #229

Conversation

qw-in commented Apr 12, 2024 • edited Loading

fwang commented May 29, 2024

qw-in commented Apr 12, 2024 •

edited

Loading